[Compatibility] Add hash expiration - HEXPIRE, HPEXPIRE, HEXPIREAT, HPEXPIREAT, HTTL, HPTTL, HEXPIRETIME, HPEXPIRETIME, HPERSIST and HCOLLECT #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@badrishc Can you quick look at this draft PR and let me know if I am going on the right path? Also, you will see a lot of TODO comments, I would like to get your opinion and help on some of those. Add your comments on those TODO items if possible. Thanks |
|
For maintaining the performance bar, we may need to: (1) Have a separate small PR to main, that adds BDN for more of the hash APIs for perf test (i.e., the ones that this PR might potentially regress). We only have one right now here: (2) Use those BDNs to compare main versus this PR, to ensure that there is no regression |
badrishc
requested changes
Dec 9, 2024
|
I think it's ready for review. Let the review comments flood it 😄 @badrishc I am working on creating a separate PR for adding more hash APIs in BDN |
main branch results as of commit
this PR branch results as of commit
Difference
For me, Variant looks minimal with the PR but I like to know your opinion. I will analyze why there is an additional allocation for HKeys, HGetAll, HVals commands |
|
I have to remove the This PR as of
Difference
For me, HMSet is the only one that looks outstanding. Update: Not sure what's going on in HMSet commands. Even after reverting everything back in HMSet commands flow, the performance is still slower than the main. But changing other parts of the code affects its performance like using |
|
Fixed all review comments except the one where we need to find the size of the new objects |
|
Please rereview this PR, closed all outstanding items from my end |
vazois
approved these changes
Dec 18, 2024
badrishc
approved these changes
Dec 18, 2024
TalZaccai
requested changes
Jan 8, 2025
libs/resources/RespCommandsInfo.json
Outdated
| @@ -1546,6 +1546,31 @@ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "Command": "HCOLLECT", | |||
There was a problem hiding this comment.
This should be added to GarnetCommandsInfo.json (in CommandInfoUpdater)
There was a problem hiding this comment.
Can you please run CommandInfoUpdater with --force and make sure that the .json files that it produces (RespCommandInfo.json & RespCommandDocs.json) are the same the existing ones? (it might move some commands around as it is alphabetizes the commands & subcommands, if the files are different please update them with the tool's outputs). Thanks!
|
@TalZaccai Fixed the review comments with some points to discuss |
TalZaccai
reviewed
Jan 15, 2025
| if (expirationTimes.TryGetValue(key, out var currentExpiration)) | ||
| { | ||
| if (expireOption.HasFlag(ExpireOption.NX) || | ||
| expireOption.HasFlag(ExpireOption.GT) && expiration <= currentExpiration || |
There was a problem hiding this comment.
I think you're missing parentheses here
| public GarnetStatus HashTimeToLive(ArgSlice key, bool isMilliseconds, bool isTimestamp, ref ObjectInput input, ref GarnetObjectStoreOutput outputFooter) | ||
| => storageSession.HashTimeToLive(key, isMilliseconds, isTimestamp, ref input, ref outputFooter, ref objectContext); | ||
|
|
||
| public GarnetStatus HashCollect(ReadOnlySpan<ArgSlice> keys, ref ObjectInput input) |
| /// </summary> | ||
| /// <param name="keys">The keys of the hash.</param> | ||
| /// <returns>The status of the operation.</returns> | ||
| GarnetStatus HashCollect(ReadOnlySpan<ArgSlice> keys, ref ObjectInput input); |
There was a problem hiding this comment.
Missing XML comment for input variable
TalZaccai
requested changes
Jan 15, 2025
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for field-specific expiration in hash set. This PR adds HEXPIRE, HPEXPIRE, HEXPIREAT, HPEXPIREAT, HTTL, HPTTL, HEXPIRETIME, HPEXPIRETIME, HPERSIST and HCOLLECT commands to garnet to support this feature.
Fixes: #857