Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Added BZMPOP, BZPOPMAX and BZPOPMIN commands #884

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding the BZMPOP, BZPOPMAX and BZPOPMIN commands to garnet

  • Add BZMPOP, BZPOPMAX and BZPOPMIN commands
  • Add Integration Test cases and ACL Test
  • Add documentation

@Vijay-Nirmal Vijay-Nirmal changed the title Added BZMPOP, BZPOPMAX and BZPOPMIN commands [Compatibility] Added BZMPOP, BZPOPMAX and BZPOPMIN commands Dec 16, 2024
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR! Thanks for the contribution. Added a few comments.

libs/server/Objects/SortedSet/SortedSetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/SortedSet/SortedSetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/SortedSet/SortedSetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Resp/Objects/SortedSetCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/Objects/SortedSetCommands.cs Outdated Show resolved Hide resolved
libs/server/Storage/Session/ObjectStore/SortedSetOps.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespBlockingTests.cs Outdated Show resolved Hide resolved
libs/server/Objects/ItemBroker/CollectionItemResult.cs Outdated Show resolved Hide resolved
libs/server/Objects/ItemBroker/CollectionItemResult.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespBlockingTests.cs Outdated Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

Fixed all review commands

Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment.

@@ -773,6 +773,110 @@
}
]
},
{
"Command": "BZMPOP",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about running CommentInfoUpdater - #864 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants