Skip to content
This repository has been archived by the owner on Dec 14, 2024. It is now read-only.

Add cf customtest command #62

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Feb 28, 2020

No description provided.

@xalanq
Copy link
Owner

xalanq commented Feb 28, 2020

Great works!
But I have changed a lot in the local repo. Maybe there would be a lot of conflicts.

@xalanq
Copy link
Owner

xalanq commented Feb 29, 2020

Pushed. You can try to solve the conflicts

@xalanq
Copy link
Owner

xalanq commented Feb 29, 2020

I think language id is not user-friendly. Any thought?

@xalanq
Copy link
Owner

xalanq commented Feb 29, 2020

Maybe you can ask what user wants, just like template configuration.

@user202729
Copy link
Contributor Author

Comment:

  • Docopt doesn't show any error messages when the format of the usage string is wrong. It just silently exits.
  • When the user provide an invalid language ID, the program will hang forever.
    It's possible to check whether the ID is valid before submitting, but it will require the language list to be up-to-date (otherwise custom test of newly added language is not possible).

@xalanq
Copy link
Owner

xalanq commented Mar 1, 2020

I think the custom test should be independent of templates. I mean you can pop out an available language list if the template detection failed instead of showing the error message.

@xalanq
Copy link
Owner

xalanq commented Mar 1, 2020

BTW the command customtest could be ctest XD

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants