Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Nunjucks Releases to Fix Syntax Loading Error #9027

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Update Nunjucks Releases to Fix Syntax Loading Error #9027

merged 2 commits into from
Jan 3, 2025

Conversation

alsolovyev
Copy link
Contributor

Changes:

  • update the releases field to include version-specific details

Notes:

Please confirm if I’ve configured everything correctly: all new releases are for version >4188, while tags: "2.0.1" remains for <=4188. This is necessary to resolve the error:

Error loading syntax file "Packages/Nunjucks/Syntaxes/Nunjucks.sublime-syntax": Apparent recursion within a with_prototype action: 25000 context sanity limit hit.

Details:

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

@alsolovyev
feat: update nunjucks package metadata improved compatibility
f408ef7 
- updated the `releases` field to include version-specific details:
  - added a release for Sublime Text `>4188` with `tags: true`
  - added a release for Sublime Text `<=4188` with `tags: "2.0.1"`
- ensures compatibility across different Sublime Text versions
  with appropriate tag references
packagecontrol-bot
packagecontrol-bot approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Nunjucks

braver
braver requested changes Jan 1, 2025
View reviewed changes
repository/n.json Outdated Show resolved Hide resolved
packagecontrol-bot
packagecontrol-bot approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - Nunjucks

@alsolovyev alsolovyev requested a review from braver January 1, 2025 22:13
@braver braver merged commit c9ac787 into wbond:master Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@packagecontrol-bot packagecontrol-bot packagecontrol-bot approved these changes

@braver braver Awaiting requested review from braver

Assignees
No one assigned
Labels
feedback provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alsolovyev @braver @packagecontrol-bot