Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Lite annex: concludedLicense -> hasConcludedLicense #1110

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Fix typo in Lite annex: concludedLicense -> hasConcludedLicense #1110

merged 3 commits into from
Sep 10, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 6, 2024

  • concludedLicense -> hasConcludedLicense
  • declaredLicense -> hasDeclaredLicense

@bact bact added the publishing label Sep 6, 2024
@bact bact added this to the 3.0.1 milestone Sep 6, 2024
@bact
Copy link
Collaborator Author

bact commented Sep 6, 2024

@NorioKobota Since this is about Lite profile, I will tag you. Please review. Thank you.

@bact bact requested review from goneall and kestewart September 6, 2024 14:28
@bact
Copy link
Collaborator Author

bact commented Sep 6, 2024 •
edited
Loading

Note: the example validation failed because the redirection of RDFs on spdx.org are not up-to-date yet. See #1108

Update: the example validation needs to be updated by #1111 as well

goneall
goneall approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall merged commit 80da85a into spdx:development/v3.0.1 Sep 10, 2024
2 of 3 checks passed
@bact bact deleted the fix-lite-typos branch September 10, 2024 15:40
@bact bact added profile: lite Lite Profile and related matters typo Typos, minor spelling errors, or minor incorrect word usage labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@zvr zvr zvr approved these changes

@kestewart kestewart Awaiting requested review from kestewart

Assignees
No one assigned
Labels
profile: lite Lite Profile and related matters publishing typo Typos, minor spelling errors, or minor incorrect word usage
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @zvr @goneall