Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MacOS integer contsant overflow compilation error #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix MacOS integer contsant overflow compilation error #80

wants to merge 2 commits into from

Conversation

akiroz
Copy link

@akiroz akiroz commented May 17, 2020

The line ifIndex > math.MaxUint32-1 throws a compilation error where int is 32 bit since int32 is signed and cannot go above 2^31 - 1.

However, I'm really curious about the original intent of this check, under what circumstances does ifIndex exceed MaxUint32 - 1 if int was int64?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akiroz