Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a timeout #6

Merged
merged 1 commit into from
Jun 23, 2015

Conversation

johanneswuerbach
Copy link
Contributor

@seidtgeist
Copy link
Owner

Thank you for the contribution! It seems like request.setTimeout is not supported yet in browserify, but there's an open pull request. Do you only need this functionality in a node context?

@johanneswuerbach
Copy link
Contributor Author

Yes, I only need it in a node context.

@johanneswuerbach
Copy link
Contributor Author

@ehd anything I could help to push this forward? :-)

@seidtgeist
Copy link
Owner

@johanneswuerbach Sorry for not getting back before. This looks fine to me, and it should work in browsers once http-browserify supports that method.

seidtgeist added a commit that referenced this pull request Jun 23, 2015
@seidtgeist seidtgeist merged commit 39729b1 into seidtgeist:master Jun 23, 2015
@johanneswuerbach johanneswuerbach deleted the timeout branch June 23, 2015 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants