Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHACS] [Docs] [4.6 only] ROX-27715: Updating release notes for 4.6.2 #87186

Open
wants to merge 1 commit into
base: rhacs-docs-4.6
Choose a base branch
from
Open

[RHACS] [Docs] [4.6 only] ROX-27715: Updating release notes for 4.6.2 #87186

wants to merge 1 commit into from
+13 −1

Conversation

agantony
Copy link
Contributor

@agantony agantony commented Jan 17, 2025 •
edited
Loading

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Source:
https://issues.redhat.com/projects/ROX/versions/12439468

Link to docs preview:
https://87186--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes#about-release-462_release-notes-46

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-27715 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony added this to the Continuous Release milestone Jan 17, 2025
@agantony agantony added the RHACS Label for RHACS related PRs that go in the rhacs-docs branch label Jan 17, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@agantony agantony added rhacs-docs-4.6 peer-review-needed Signifies that the peer review team needs to review this PR and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-27715 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Source:
https://issues.redhat.com/projects/ROX/versions/12439468

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2025
@ocpdocs-previewbot
Copy link

🤖 Fri Jan 17 08:52:18 - Prow CI generated the docs preview:
https://87186--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2025

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-27715 which is a valid jira issue.

In response to this:

Version(s):
4.6

Issue:
https://issues.redhat.com/browse/ROX-27715

Source:
https://issues.redhat.com/projects/ROX/versions/12439468

Link to docs preview:
https://87186--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/46-release-notes#about-release-462_release-notes-46

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-4.6
  • No cherry-pick needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2025
xenolinux
xenolinux reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments; otherwise LGTM

release_notes/46-release-notes.adoc

This release of {product-title-short} fixes the following bugs:

* Fixed an issue in StackRox Scanner V2 where scan results for Red Hat Enterprise Linux (RHEL)-based images displayed inaccurate package and vulnerability data due to incorrect layer hierarchy assumptions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using an attribute:
:op-system-base-full: Red{nbsp}Hat Enterprise Linux (RHEL)

release_notes/46-release-notes.adoc

* Fixed an issue in StackRox Scanner V2 where scan results for Red Hat Enterprise Linux (RHEL)-based images displayed inaccurate package and vulnerability data due to incorrect layer hierarchy assumptions.

* Fixed an issue where the output format of the `roxctl` CLI command for timestamps changed in {product-title-short} 4.6, interrupting customer automation workflows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed an issue where the output format of the `roxctl` CLI command for timestamps changed in {product-title-short} 4.6, interrupting customer automation workflows.
* Fixed an issue where the output format of the `roxctl` command for timestamps changed in {product-title-short} 4.6, interrupting customer automation workflows.

"CLI command" is redundant. You can use either of them.

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.6 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
4 participants
@agantony @openshift-ci-robot @ocpdocs-previewbot @xenolinux