-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPNET-629: Add second HAProxy healthcheck port #1728
base: master
Are you sure you want to change the base?
Conversation
In order to improve the robustness of the on-prem HAProxy instance, we have added a second healthcheck port in openshift/machine-config-operator#4767 This corresponds to the existing 9444 port, but because the surrounding ports were already in use I moved it an even 10 away.
@cybertron: This pull request references OPNET-629 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold I wanted to get this proposed, but before we merge it I want to get reviews on the dependent patch to ensure we actually implement this. |
@cybertron: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
In order to improve the robustness of the on-prem HAProxy instance, we have added a second healthcheck port in
openshift/machine-config-operator#4767 This corresponds to the existing 9444 port, but because the surrounding ports were already in use I moved it an even 10 away.