Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for opt-in caching #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simon-paris
Copy link

This adds caching, which is off by default and enabled using {caching: "always"}. It works by mapping from snapshots provided by typescript to snapshots generated by the plugin using a WeakMap.

The caching option allows "always" | "never". I chose to use a union instead of a bool to 1) later support for a third "only when safe" or "only when supported" option, and 2) to help indicate that it might be too aggressive since "always" sounds stronger than true.

Fixes #215

cc @jsliang

@simon-paris
Copy link
Author

Hi @mrmckeb, would you be able to review this?

@mrmckeb mrmckeb added this to the v6.0.0 milestone Oct 10, 2024
@mrmckeb
Copy link
Owner

mrmckeb commented Oct 10, 2024

Hi @simon-paris, sorry for the long delay. I changed jobs and moved cities over the last few months and didn't get much free time for open source.

I'll take a look at this with some other changes this weekend hopefully! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode Intellisense with version 5 is very slow
2 participants