add minification precommit hook #6059
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a minification precommit hook. But is currently probably blocked on high severity issues, until https://github.com/kevva/download/pull/220/files is merged. I cannot simply `resolve` got to 12.x, because that uses ESM which errors out if imported from the non-esm download module.
goodwillhunting9
approved these changes
Oct 27, 2023
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
goodwillhunting9
approved these changes
Oct 27, 2023
ramosare
reviewed
Nov 10, 2023
| import imagemin from "imagemin"; | ||
| import { promises as fs } from "fs"; | ||
|
|
||
| import gifsicle from "imagemin-gifsicle"; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@connor4312 Is this still relevant or can this be closed? |
11234568
reviewed
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minification precommit hook. But is currently probably blocked on high severity issues, until https://github.com/kevva/download/pull/220/files is merged.
I cannot simply
resolvegot to 12.x, because that uses ESM which errors out if imported from the non-esm download module.