[QNN EP] Fix regression for MatMul with two quantized/dynamic uint16 inputs #23419
+355
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
commented
Jan 17, 2025
adrianlizarraga
requested review from
HectorSVC,
centwang and
jywu-msft
and removed request for
HectorSVC
HectorSVC
approved these changes
Jan 17, 2025
adrianlizarraga
deleted the
adrianl/matmul-dynamic-uint16-inputs-regression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ONNX MatMul -> QNN MatMulandONNX MatMul -> QNN FullyConnectedto separate functions to make the code more readable.Motivation and Context
The following PR updated the handling of MatMul. The logic to handle MatMul with two non-const uint16 inputs was not ported from simple_op_builder.cc to the new matmul_op_builder.cc.
#22639