Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "NewParent" to "NewParentItem" #1692

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Rename "NewParent" to "NewParentItem" #1692

merged 1 commit into from
Nov 28, 2019

Conversation

kaiguo
Copy link
Contributor

@kaiguo kaiguo commented Nov 27, 2019 •
edited
Loading

Description

Renamed TreeViewDragItemsCompletedEventArgs.NewParent to TreeViewDragItemsCompletedEventArgs.NewParentItem based on API review feedback.

Also removed preview tag.

Motivation and Context

Address feedback from microsoft/microsoft-ui-xaml-specs#54.

How Has This Been Tested?

Covered by interaction tests.

@jevansaks
Copy link
Member

NewParentItem sounds much better to me too, thanks!

@jevansaks jevansaks added this to the WinUI 2.3 milestone Nov 27, 2019
@kaiguo kaiguo merged commit f3467f4 into master Nov 28, 2019
@kaiguo kaiguo deleted the user/kaiguo/treeview-api-feedback branch November 28, 2019 00:01
@kaiguo kaiguo self-assigned this Nov 28, 2019
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Nov 30, 2019
@marcelwgn marcelwgn mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jevansaks jevansaks jevansaks approved these changes

Assignees

@kaiguo kaiguo

Labels
area-TreeView release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
WinUI 2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiguo @jevansaks