Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaneTitle to NavigationViewTemplateSettings #18

Closed

Conversation

licanhua
Copy link

@licanhua licanhua requested a review from MikeHillberg March 13, 2019 20:45
```

# Remarks
This is intended for use in the style of the `NavigationView` control. Sample usage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the template, not in the style

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Templatesetting is used in the style

This is intended for use in the style of the `NavigationView` control. Sample usage:

```xaml
<Style TargetType="local:NavigationView">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a template example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand? TemplateSettings.PaneTitle example is always in the style

Text="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.PaneTitle}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in the ControlTemplate, and the ControlTemplate is typically part of the default Style. (That Text property is on a TextBlock in a ControlTemplate.) PersonPictureSettings (#13) is a good reference.

This API update addes PaneTitle [Template-Settings](https://docs.microsoft.com/en-us/windows/uwp/xaml-platform/template-settings-classes) to the NavigationView control.

# Description
Provides calculated PaneTitle that can be referenced as TemplatedParent sources when defining templates for a NavigationView control. Not intended for general use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Provides calculated PaneTitle that can be referenced as TemplatedParent sources when defining templates for a NavigationView control. Not intended for general use.
Provides the calculated PaneTitle that should be displayed by a ControlTemplate.
This will be null if the PaneHeader property is set.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Provides calculated PaneTitle that can be referenced as TemplatedParent sources when defining templates for a NavigationView control. Not intended for general use.
Provides the calculated PaneTitle that should be displayed by a ControlTemplate.
This will be empty if the PaneHeader property is set.

This is intended for use in the style of the `NavigationView` control. Sample usage:

```xaml
<Style TargetType="local:NavigationView">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in the ControlTemplate, and the ControlTemplate is typically part of the default Style. (That Text property is on a TextBlock in a ControlTemplate.) PersonPictureSettings (#13) is a good reference.


```
[webhosthidden]
unsealed runtimeclass NavigationViewTemplateSettings : Windows.UI.Xaml.DependencyObject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't an Example, this is the API, and should be in the API Details section. The "sample usage" from the Remarks section should be brought up here.

@licanhua
Copy link
Author

This is abandoned and bug would be a document bug.

@licanhua licanhua closed this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants