-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PaneTitle to NavigationViewTemplateSettings #18
Add PaneTitle to NavigationViewTemplateSettings #18
Conversation
active/NavigationView/NavigationViewTemplateSettings/PaneTitle.md
Outdated
Show resolved
Hide resolved
active/NavigationView/NavigationViewTemplateSettings/PaneTitle.md
Outdated
Show resolved
Hide resolved
active/NavigationView/NavigationViewTemplateSettings/PaneTitle.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: licanhua <[email protected]>
Co-Authored-By: licanhua <[email protected]>
active/NavigationView/NavigationViewTemplateSettings/PaneTitle.md
Outdated
Show resolved
Hide resolved
``` | ||
|
||
# Remarks | ||
This is intended for use in the style of the `NavigationView` control. Sample usage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the template, not in the style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Templatesetting is used in the style
This is intended for use in the style of the `NavigationView` control. Sample usage: | ||
|
||
```xaml | ||
<Style TargetType="local:NavigationView"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a template example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand? TemplateSettings.PaneTitle example is always in the style
Text="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.PaneTitle}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used in the ControlTemplate, and the ControlTemplate is typically part of the default Style. (That Text property is on a TextBlock in a ControlTemplate.) PersonPictureSettings (#13) is a good reference.
active/NavigationView/NavigationViewTemplateSettings/PaneTitle.md
Outdated
Show resolved
Hide resolved
active/NavigationView/NavigationViewTemplateSettings/PaneTitle.md
Outdated
Show resolved
Hide resolved
active/NavigationView/NavigationViewTemplateSettings/PaneTitle.md
Outdated
Show resolved
Hide resolved
This API update addes PaneTitle [Template-Settings](https://docs.microsoft.com/en-us/windows/uwp/xaml-platform/template-settings-classes) to the NavigationView control. | ||
|
||
# Description | ||
Provides calculated PaneTitle that can be referenced as TemplatedParent sources when defining templates for a NavigationView control. Not intended for general use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provides calculated PaneTitle that can be referenced as TemplatedParent sources when defining templates for a NavigationView control. Not intended for general use. | |
Provides the calculated PaneTitle that should be displayed by a ControlTemplate. | |
This will be null if the PaneHeader property is set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provides calculated PaneTitle that can be referenced as TemplatedParent sources when defining templates for a NavigationView control. Not intended for general use. | |
Provides the calculated PaneTitle that should be displayed by a ControlTemplate. | |
This will be empty if the PaneHeader property is set. |
This is intended for use in the style of the `NavigationView` control. Sample usage: | ||
|
||
```xaml | ||
<Style TargetType="local:NavigationView"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used in the ControlTemplate, and the ControlTemplate is typically part of the default Style. (That Text property is on a TextBlock in a ControlTemplate.) PersonPictureSettings (#13) is a good reference.
|
||
``` | ||
[webhosthidden] | ||
unsealed runtimeclass NavigationViewTemplateSettings : Windows.UI.Xaml.DependencyObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't an Example, this is the API, and should be in the API Details section. The "sample usage" from the Remarks section should be brought up here.
Co-Authored-By: licanhua <[email protected]>
Co-Authored-By: licanhua <[email protected]>
This is abandoned and bug would be a document bug. |
Linked pullrequest If both PaneHeader and PaneTitle are set, use PaneHeader