Skip to content

Commit

Permalink
Only run unit_tests in Debug flavor with AppVerifier memory checks in…
Browse files Browse the repository at this point in the history
… the nightly CI run. (#3056)

* Only run unit tests with AppVerifier in the nightly CI run.

* Run with appverif side by side.

* remove subsets of appverif checks

* more testing

* Remove Heaps, Leak check in AppVerifier for Debug PR builds.

---------

Co-authored-by: Igor Klemenski <[email protected]>
  • Loading branch information
rectified95 and Igor Klemenski authored Nov 21, 2023
1 parent e6f3f24 commit e804df4
Showing 1 changed file with 20 additions and 2 deletions.
22 changes: 20 additions & 2 deletions .github/workflows/cicd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ jobs:
configurations: '["NativeOnlyDebug", "NativeOnlyRelease"]'

# Run the unit tests in GitHub.
unit_tests:
unit_tests_appverif:
# Always run this job.
needs: regular
if: github.event_name == 'schedule' || github.event_name == 'pull_request' || github.event_name == 'push' || github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
uses: ./.github/workflows/reusable-test.yml
with:
name: unit_tests
Expand All @@ -84,6 +84,24 @@ jobs:
capture_etw: true
leak_detection: true

# Run the unit tests in GitHub.
unit_tests:
# Always run this job.
needs: regular
if: github.event_name == 'pull_request' || github.event_name == 'push' || github.event_name == 'merge_group'
uses: ./.github/workflows/reusable-test.yml
with:
name: unit_tests
pre_test: appverif -enable Exceptions Handles Locks Memory SRWLock Threadpool TLS DangerousAPIs DirtyStacks TimeRollOver -for unit_tests.exe
# Exclude [processes] test that CodeCoverage can't work with.
test_command: .\unit_tests.exe -d yes ~[processes]
build_artifact: Build-x64
environment: windows-2022
code_coverage: true
gather_dumps: true
capture_etw: true
leak_detection: true

# Run the netebpfext unit tests in GitHub.
netebpf_ext_unit_tests:
# Always run this job.
Expand Down

0 comments on commit e804df4

Please sign in to comment.