Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specjbb parser parses N/A metrics gracefully #346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

specjbb parser parses N/A metrics gracefully #346

wants to merge 1 commit into from

Conversation

nmalkapuram
Copy link
Contributor

yangpanMS
yangpanMS requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor to use double.NaN for not valid result. Also when will we have nan output?

@yangpanMS
Copy link
Contributor

Do we still need this? Can I close it?

@yangpanMS yangpanMS marked this pull request as draft August 20, 2024 18:47
@yangpanMS
Copy link
Contributor

Closing. Please reopen as needed.

@yangpanMS yangpanMS closed this Oct 28, 2024
@nmalkapuram nmalkapuram reopened this Jan 9, 2025
@nmalkapuram nmalkapuram marked this pull request as ready for review January 9, 2025 09:42
yangpanMS
yangpanMS requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the constructor will immediately break internal repo and partner extensions. Let's make sure this is necessary before proceeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangpanMS yangpanMS yangpanMS requested changes

@alexffrank alexffrank alexffrank approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmalkapuram @yangpanMS @alexffrank