refactor(container-runtime): Enable various eslint rules from our "recommended" config and fix violations #23609
+542
−395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus a couple of comment improvements
github-actions
bot
added
base: main
Josmithr
commented
Jan 17, 2025
| "unicorn/switch-case-braces": "error", | ||
| "unicorn/throw-new-error": "error", | ||
|
|
||
| // TODO: |
There was a problem hiding this comment.
Future PR (trying to keep these PRs somewhat scoped so they're easier to review)
There was a problem hiding this comment.
Copilot reviewed 62 out of 77 changed files in this pull request and generated no comments.
Files not reviewed (15)
- common/build/eslint-config-fluid/printed-configs/default.json: Language not supported
- common/build/eslint-config-fluid/printed-configs/react.json: Language not supported
- common/build/eslint-config-fluid/printed-configs/recommended.json: Language not supported
- common/build/eslint-config-fluid/printed-configs/strict-biome.json: Language not supported
- common/build/eslint-config-fluid/printed-configs/strict.json: Language not supported
- common/build/eslint-config-fluid/printed-configs/test.json: Language not supported
- packages/runtime/container-runtime/src/containerRuntime.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/opLifecycle/duplicateBatchDetector.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/opLifecycle/opCompressor.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/gc/gcSummaryStateTracker.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/dataStoreContext.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/dataStore.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/channelCollection.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/gc/gcTelemetry.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/blobManager/blobManagerSnapSum.ts: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One in a series of PRs working towards migrating the package to our
recommendedconfig.Enables the following rules, which are included in our "recommended" config:
unicorn/catch-error-nameunicorn/consistent-destructuringunicorn/new-for-builtinsunicorn/no-array-callback-referenceunicorn/no-array-for-eachunicorn/no-nullunicorn/no-zero-fractionsunicorn/prefer-node-protocolunicorn/prefer-number-propertiesunicorn/prefer-optional-catch-bindingunicorn/prefer-spreadunicorn/prefer-string-sliceunicorn/switch-case-bracesunicorn/throw-new-errorAlso disables the
unicorn/no-array-push-pushrule in our shared config due false positives for non-array types with methods named "push".AB#3027