Added assert for compression ON grouping OFF #23608
Draft
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: main
MarioJGMsoft
changed the title
Some places tried to use undefined to disable. This does not work, it gets replaced with default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We no longer want to make it possible to create a container that has grouping off and compression off, so we will throw an error if we detect that it has been created that way.
Acceptance Criteria
A container throws an error when it is configured with compression on and grouping off.
Execution Plan
Add code to container runtime
Update related tests to make sure that they expect an error to be thrown.
Reviewer Guidance
Please let me know if there's something that I'm missing or that I should know about. Thanks!
Fixes: AB#28625