build(client): Pass --ci flag when invoking jest #23596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 7 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (20)
- common/lib/common-utils/package.json: Language not supported
- examples/apps/collaborative-textarea/package.json: Language not supported
- examples/apps/contact-collection/package.json: Language not supported
- examples/apps/data-object-grid/package.json: Language not supported
- examples/apps/presence-tracker/package.json: Language not supported
- examples/apps/task-selection/package.json: Language not supported
- examples/apps/tree-comparison/package.json: Language not supported
- examples/benchmarks/bubblebench/baseline/package.json: Language not supported
- examples/benchmarks/bubblebench/experimental-tree/package.json: Language not supported
- examples/benchmarks/bubblebench/ot/package.json: Language not supported
- examples/benchmarks/bubblebench/shared-tree/package.json: Language not supported
- examples/data-objects/canvas/package.json: Language not supported
- examples/data-objects/clicker/package.json: Language not supported
- examples/data-objects/diceroller/package.json: Language not supported
- examples/data-objects/inventory-app/package.json: Language not supported
- examples/data-objects/multiview/container/package.json: Language not supported
- examples/data-objects/todo/package.json: Language not supported
- examples/version-migration/live-schema-upgrade/package.json: Language not supported
- examples/version-migration/same-container/package.json: Language not supported
- examples/version-migration/separate-container/package.json: Language not supported
github-actions
bot
added
area: driver
jason-ha
approved these changes
Jan 17, 2025
| @@ -31,7 +31,7 @@ | |||
| "start": "webpack serve", | |||
| "start:client:test": "webpack serve --config webpack.test.cjs", | |||
| "test": "npm run test:jest", | |||
| "test:jest": "jest", | |||
| "test:jest": "jest --ci", | |||
| "test:jest:verbose": "cross-env FLUID_TEST_VERBOSE=1 jest --passWithNoTests", | |||
There was a problem hiding this comment.
jest invocation without --ci - perhaps this is a special case (others don't have --passWithNoTests)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jest CLI
--ciflag cannot be set in its config file like other settings, but it defaults to isCI from the is-ci package, which in turn uses ci-info, which supports azure. So the flag should already be set to true by default in CI even without setting it explicitly. However, to be capable of running tests in an environment as close to CI as possible, even when running locally, the scripts have been updated to pass the--ciflag whenever jest is invoked.Alternative to #23590.