Stubbed out branching example #23595
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: examples
There was a problem hiding this comment.
Copilot reviewed 15 out of 30 changed files in this pull request and generated no comments.
Files not reviewed (15)
- examples/apps/branching/.gitignore: Language not supported
- examples/apps/branching/.npmignore: Language not supported
- examples/apps/branching/LICENSE: Language not supported
- examples/apps/branching/biome.jsonc: Language not supported
- examples/apps/branching/package.json: Language not supported
- examples/apps/branching/src/index.html: Language not supported
- examples/apps/branching/src/start.ts: Evaluated as low risk
- examples/apps/branching/src/model/index.ts: Evaluated as low risk
- examples/apps/branching/src/model/groceryList.ts: Evaluated as low risk
- examples/apps/branching/src/view/debugView.tsx: Evaluated as low risk
- examples/apps/branching/prettier.config.cjs: Evaluated as low risk
- examples/apps/branching/src/view/groceryListView.tsx: Evaluated as low risk
- examples/apps/branching/src/modelInterfaces.ts: Evaluated as low risk
- examples/apps/branching/src/healthBot.ts: Evaluated as low risk
- examples/apps/branching/jest-puppeteer.config.cjs: Evaluated as low risk
Comments suppressed due to low confidence (2)
examples/apps/branching/src/model/containerCode.ts:18
- [nitpick] The variable name 'groceryListId' is too similar to 'groceryListRegistryKey'. Consider renaming it to 'groceryListDataStoreId' for clarity.
const groceryListId = "grocery-list";
examples/apps/branching/src/model/containerCode.ts:19
- [nitpick] The variable name 'groceryListRegistryKey' is too similar to 'groceryListId'. Consider renaming it to 'groceryListRegistryEntryKey' for clarity.
const groceryListRegistryKey = "grocery-list";
ChumpChief
commented
Jan 17, 2025
| return branchedMap; | ||
| }; | ||
|
|
||
| const branch = async () => { |
There was a problem hiding this comment.
Fake branching here. I think it should be fairly straightforward to integrate @anthony-murphy 's prototype here AFAICT, but I haven't actually tried.
ChumpChief
commented
Jan 17, 2025
| const branchedMap = branchMap(map); | ||
| // TODO: Should there be a working handle here? What would that mean? | ||
| // eslint-disable-next-line @typescript-eslint/consistent-type-assertions | ||
| return new GroceryList(runtime, {} as IFluidHandle<FluidObject>, branchedMap, () => { |
There was a problem hiding this comment.
Note that I'm creating a whole second data store class instance (GroceryList) rather than just a second map. This seems easier to integrate into the view layer since I can just reuse the existing GroceryListView and don't have to make that view branch-aware. And also the data store itself doesn't have to be particularly knowledgeable about its branched state.
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new example package for the branching feature. For now, just "fakes" branching, to be filled in as the feature develops. But in the meantime it's useful for thinking through what the customer interaction and app integration pieces could possibly look like.