Prefix no-unchecked-record-access for presence #23581
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
jason-ha
reviewed
Jan 16, 2025
Comment on lines
400
to
401
| let workspaceDatastore = this.datastore[workspaceAddress]; | ||
| let workspaceDatastore: ValueElementMap<PresenceStatesSchema> | undefined = this.datastore[workspaceAddress]; |
There was a problem hiding this comment.
This type of change does not work. We already need to undo all of the similar changes. See comments in other related PRs. Please do not add more.
jason-ha
reviewed
Jan 16, 2025
Comment on lines
120
to
+123
| mergedData[valueManagerKey] ??= {}; | ||
| const oldData = mergedData[valueManagerKey][clientSessionId]; | ||
| mergedData[valueManagerKey][clientSessionId] = mergeValueDirectory( | ||
| const oldData = mergedData[valueManagerKey]?.[clientSessionId]; | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| mergedData[valueManagerKey]![clientSessionId] = mergeValueDirectory( |
There was a problem hiding this comment.
This is clearly not problematic. Line 120 ensures that mergedData[valueManagerKey] is defined.
So ? is definitely not appropriate.
no-unchecked-record-access is already enabled for this package. Why are there new issues being reported? (If a change in rule pending, did it do better before. The code is correct; so, don't want to see anything flagged here.)
|
The remaining changes to just enable noUncheckedIndexAccess for presence aren't so bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix no-unchecked-record-access for presence