Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add ability to get classDefs from classDb #6190

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

yari-dewalt
Copy link
Collaborator

📑 Summary

Creates and exposes public function to fetch classDefs inside the classDb. Also includes change to properly split styles when inserting into its object styles array.

📏 Design Decisions

getClassDefs() returns the defined style classes from inside the classDb so we have access to them.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: cb74341

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Other Not an enhancement or a bug label Jan 14, 2025
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit cb74341
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67880d97aa54290008f5f5b7
😎 Deploy Preview https://deploy-preview-6190--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 14, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6190
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6190
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6190
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6190

commit: cb74341

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 4.47%. Comparing base (bc2cc61) to head (abd7ca2).

Files with missing lines Patch % Lines
packages/mermaid/src/diagrams/class/classDb.ts 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6190   +/-   ##
=======================================
  Coverage     4.47%   4.47%           
=======================================
  Files          383     382    -1     
  Lines        54142   54138    -4     
  Branches       596     621   +25     
=======================================
  Hits          2425    2425           
+ Misses       51717   51713    -4     
Flag Coverage Δ
unit 4.47% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/class/classDb.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@yari-dewalt
Copy link
Collaborator Author

E2E tests failing as of right now due to argos but they should actually be good.

Error: You have reached the maximum screenshot capacity included in your Pro open source xl Plan. Please upgrade your Plan.

Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Other Not an enhancement or a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants