Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry on database connection #5772

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jordanrfrazier
Copy link
Collaborator

DSLFv2 spins up a knative service running a langflow pod that immediately attempts to start in tandem while the database manager creates the appropriate tenant in the postgresql schema. Pods must give the database services time to create the tenant; this PR adds a short (and optional) retry on startup.

@github-actions github-actions bot added the enhancement New feature or request label Jan 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
Copy link

codspeed-hq bot commented Jan 17, 2025

CodSpeed Performance Report

Merging #5772 will degrade performances by 33.07%

Comparing impl-db-retry (1e0d9ca) with main (88111c3)

Summary

❌ 3 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main impl-db-retry Change
test_successful_run_with_input_type_any 262.2 ms 344 ms -23.78%
test_successful_run_with_input_type_text 175.5 ms 262.2 ms -33.07%
test_successful_run_with_output_type_debug 173.7 ms 254.3 ms -31.73%

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant