sig-scalability: add inference-perf subproject #8247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madhav Jivrajani <[email protected]>
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MadhavJivrajani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
wojtek-t
reviewed
Jan 15, 2025
| @@ -49,6 +49,10 @@ subprojects, and resolve cross-subproject technical issues and decisions. | |||
| ## Subprojects | |||
|
|
|||
| The following [subprojects][subproject-definition] are owned by sig-scalability: | |||
| ### inference-perf | |||
There was a problem hiding this comment.
nit: let's move it to the end of subprojects list, as the newest one
There was a problem hiding this comment.
Should this be alphabetically ranked?
| @@ -49,6 +49,10 @@ subprojects, and resolve cross-subproject technical issues and decisions. | |||
| ## Subprojects | |||
|
|
|||
| The following [subprojects][subproject-definition] are owned by sig-scalability: | |||
| ### inference-perf | |||
| [Described below](#inference-perf) | |||
There was a problem hiding this comment.
Can you please add a section for that, just leave a TODO in this section to fill it in
| @@ -2732,6 +2732,10 @@ sigs: | |||
| github: aojea | |||
| name: Antonio Ojea | |||
| subprojects: | |||
| - name: inference-perf | |||
There was a problem hiding this comment.
nit: same here - move to the bottom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref kubernetes/org#5334
/assign @wojtek-t
for LGTM
/hold