fix performance in convert engine: exif orientation #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other calls to the ImageMagick commandline tools, the suffix "[0]" is added so it only looks at the first page if it's a multi-page document such as a PDF. For some reason, this is missing in the `_get_exif_orientation()` method, and may cause very long runtimes when dealing with large documents (several hundred pages of PDF).
winged
force-pushed
the
fix_exif_orientation_speed
branch
from
ac4b001 to
dbac583
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 74.07% 74.09% +0.01%
==========================================
Files 26 26
Lines 1678 1679 +1
==========================================
+ Hits 1243 1244 +1
Misses 435 435 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other calls to the ImageMagick commandline tools in the same class, the suffix "[0]" is added so it only looks at the first page if it's a multi-page document such as a PDF.
For some reason, this is missing in the
_get_exif_orientation()method, and may cause very long runtimes when dealing with large documents (several hundred pages of PDF).I had a roughly 300 page PDF (plain text only, about 2.5MB) to reproduce, and the runtime of the
get_thumbnail()call went down from around 90s to roughly 600ms.