Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build dependencies of cached packages #196

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

WVerlaek
Copy link
Member

Description

Fixes build failure if the dependency of a cached package (no longer) exists in the cache. Now, also checks and builds if needed the dependencies of packages that are already built (in cache).

Drive-by fixes:

  • unkown -> unknown
  • ignore empty lines in .leewayignore. An empty line would otherwise match every file path and ignore everything

Related Issue(s)

Fixes https://gitpod.slack.com/archives/C06C23ZTFL6/p1733906120191529

How to test

Documentation

/hold

pkg/leeway/build.go Outdated Show resolved Hide resolved
Co-authored-by: Mads Hartmann <[email protected]>
@WVerlaek WVerlaek merged commit 25dc424 into main Dec 19, 2024
6 checks passed
@WVerlaek WVerlaek deleted the wv/fix-transitive-dependency-cache-miss branch December 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants