Merge pull request #18503 from MathiasVP/scanf-check-prepare-fix

C++: Harden `checkedForEof`
github · Jan 16, 2025 · a0d2213 · a0d2213
2 parents 90faab4 + 01cbd2f
commit a0d2213
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cpp/ql/src/Critical/ScanfChecks.qll b/cpp/ql/src/Critical/ScanfChecks.qll
@@ -37,7 +37,7 @@ private string getEofValue() {
  */
 private predicate checkedForEof(ScanfFunctionCall call) {
   exists(IRGuardCondition gc |
-    exists(Instruction i | i.getUnconvertedResultExpression() = call |
+    exists(CallInstruction i | i.getUnconvertedResultExpression() = call |
       exists(int val | gc.comparesEq(valueNumber(i).getAUse(), val, _, _) |
         // call == EOF
         val = getEofValue().toInt()