feat: PR to Support GitHub Enterprise Cloud with Data Residency #4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neethu-p
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
This PR is raised to enhance the module’s functionality to support GitHub Enterprise Cloud with data residency.
Reference issue - #4364
Below are the details of the changes:
ghe.com, in addition to the current handling ofgithub.comand GHES.2.The primary difference between
github.comandghe.comis the API access URL. Whilegithub.comuseshttps://api.github.com, GHE Cloud instances use the formathttps://api.domain.ghe.com.To accommodate this, I have utilised the existing
ghes_urlparameter. The newghe.comURL can be passed to this parameter for smooth integration.This change has been thoroughly tested across all GitHub instances: GHES,
github.com, andghe.com, ensuring compatibility and reliability.Please review the PR and let me know if you have any feedback or suggestions.