fix(eap-api): Snuba can receive val_double
in addition to val_float
#6783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry sends RPC request containing
val_float
to Snuba (code here). Snuba receives the request. Snuba then sends response containingval_float
to Sentry (code here). Sentry receives the response.Plan:
val_double
andval_float
val_float
in the sending end of both Sentry and Snuba toval_double
. This replacement (instead of supporting both) is backward compatible because step 1 ensures that both receiving ends can handle eitherval_float
orval_double
val_float
from the receiving end of both Sentry and SnubaNote: "after some time" means all instances of Sentry and Snuba have the updated code
This PR handles the Snuba side of step 1. PR for handling the Sentry side of step 1 is here