Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eap-api): Snuba can receive val_double in addition to val_float #6783

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xurui-c
Copy link
Member

@xurui-c xurui-c commented Jan 16, 2025

Sentry sends RPC request containing val_float to Snuba (code here). Snuba receives the request. Snuba then sends response containing val_float to Sentry (code here). Sentry receives the response.

Plan:

  1. update the receiving end of both Sentry and Snuba to support both val_double and val_float
  2. after some time, replace the val_float in the sending end of both Sentry and Snuba to val_double. This replacement (instead of supporting both) is backward compatible because step 1 ensures that both receiving ends can handle either val_float or val_double
  3. after some time, remove val_float from the receiving end of both Sentry and Snuba

Note: "after some time" means all instances of Sentry and Snuba have the updated code

This PR handles the Snuba side of step 1. PR for handling the Sentry side of step 1 is here

@xurui-c xurui-c changed the title receiving end fix(eap-api): receiving end handles val_double in addition to val_float Jan 16, 2025
@xurui-c xurui-c changed the title fix(eap-api): receiving end handles val_double in addition to val_float fix(eap-api): Snuba can receive val_double in addition to val_float Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant