Update

getsentry · Jan 17, 2025 · 00841b8 · 00841b8
1 parent 33366b7
commit 00841b8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/integrations/codecov/codecov_auth.py b/src/integrations/codecov/codecov_auth.py
@@ -43,7 +43,7 @@ def authenticate_incoming_request(
     @inject
     def authenticate_codecov_app_install(
         external_owner_id: str, repo_service_id: str, config: AppConfig = injected
-    ):
+    ) -> bool:
         data = {"external_owner_id": external_owner_id, "repo_service_id": repo_service_id}
         request_data = json.dumps(data).encode("utf-8")
         key = config.CODECOV_OUTGOING_SIGNATURE_SECRET

diff --git a/src/seer/app.py b/src/seer/app.py
@@ -7,7 +7,7 @@
 from openai import APITimeoutError
 from sentry_sdk.integrations.flask import FlaskIntegration
 from sentry_sdk.integrations.logging import LoggingIntegration
-from werkzeug.exceptions import GatewayTimeout, InternalServerError
+from werkzeug.exceptions import GatewayTimeout, InternalServerError, Unauthorized
 
 from integrations.codecov.codecov_auth import (
     INCOMING_REQUEST_SIGNATURE_HEADER,
@@ -275,6 +275,9 @@ def codecov_request_endpoint(
     data: CodecovTaskRequest,
 ) -> CodegenBaseResponse:
     signature = request.headers.get(INCOMING_REQUEST_SIGNATURE_HEADER)
+    if not signature:
+        raise Unauthorized("Missing signature")
+
     CodecovAuthentication.authenticate_incoming_request(signature, data)
 
     is_valid = CodecovAuthentication.authenticate_codecov_app_install(