[FIL-461] Get rid of the matches #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
requested changes
Jan 7, 2025
Comment on lines
25
to
35
| match LDNApplication::load_from_db(id, owner, repo).await { | ||
| Ok(app_file) => match serde_json::to_string_pretty(&app_file) { | ||
| Ok(response) => HttpResponse::Ok().body(response), | ||
| Err(_) => { | ||
| Ok(app_file) => { | ||
| if let Ok(response) = serde_json::to_string_pretty(&app_file) { | ||
| HttpResponse::Ok().body(response) | ||
| } else { | ||
| HttpResponse::InternalServerError().body("Failed to serialize success message") | ||
| } | ||
| }, | ||
| } | ||
| Err(e) => HttpResponse::BadRequest().body(e.to_string()), | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there a way to refactor it better? match -> if let doesn't really give us much, it's still nested code.
Ideally, I'd like to see something like this? Not tested though:
let app_file = LDNApplication::load_from_db(id, owner, repo).await.map_err(ErrorNotFound)?;
let body = serde_json::to_string_pretty(&app_file).map_err(ErrorInternalServerError)?;
HttpResponse::Ok().body(body)https://docs.rs/actix-web/latest/actix_web/error/fn.ErrorNotFound.html
https://docs.rs/actix-web/latest/actix_web/error/fn.ErrorInternalServerError.html
There was a problem hiding this comment.
Applies to other instances in this PR as well.
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
kacperzuk-neti
approved these changes
Jan 14, 2025
Filip-L
force-pushed
the
FIL-461-try-to-get-rid-of-the-matches
branch
from
f746860 to
6b49281
Compare
Filip-L
temporarily deployed
to
production-fidl
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.