Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue#2362, build debug version failed with msvc(vs2022 v143) on windows #2363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

fix: issue#2362, build debug version failed with msvc(vs2022 v143) on windows #2363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/fbcode_builder/getdeps/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,7 +1289,7 @@ def _build(self, reconfigure) -> None:
+ [
"link=%s" % link,
"runtime-link=shared",
"variant=release",
f"variant={self.build_opts.build_type.lower()}",
"threading=multi",
"debug-symbols=on",
"visibility=global",
Expand Down
4 changes: 4 additions & 0 deletions folly/container/test/heap_vector_types_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ struct OneAtATimePolicy {

template <typename T>
struct CountingAllocator : std::allocator<T> {
CountingAllocator() noexcept = default;
template <typename U>
CountingAllocator(const CountingAllocator<U>&) noexcept {}

T* allocate(std::size_t n) {
nAllocations += 1;
return std::allocator<T>::allocate(n);
Expand Down
2 changes: 1 addition & 1 deletion folly/test/FunctionRefTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ TEST(FunctionRef, Emptiness) {
// models std::function
struct NullptrTestableInSitu {
int res;
[[maybe_unused]] explicit NullptrTestableInSitu(std::nullptr_t);
[[maybe_unused]] explicit NullptrTestableInSitu(std::nullptr_t) {}
explicit NullptrTestableInSitu(int i) : res(i) {}
CastableToBool operator==(std::nullptr_t) const { return res % 3 != 1; }
int operator()(int in) const { return res * in; }
Expand Down