Remove array allocation during SystemParametersInfo cache invalidation #10246
+48
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes array allocation during
SystemParametersInfo
cache invalidation when a theme is changed, saving unnecessary allocation and overhead. We could alternatively keep it in method, while that removes the allocation it won't provide the 10ns execution benefit due to the stack init, and imho there's no reason why it couldn't be outside method, there's no readibility issue.Method execution difference
Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build.
Risk
Minimal, just getting the data from binary directly instead of heap-allocating an array.
Microsoft Reviewers: Open in CodeFlow