PGO artifacts are vertical visibility by default except for dotnet-sdk-pgo-* #46063
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
They're consumed by dotnet-optimization to generate the next set of PGO data to feed back into dotnet/runtime. |
| @@ -95,6 +95,8 @@ | |||
| <BuildArgs>$(BuildArgs) /p:SourceBuiltAssetManifestsDir=$(RepoAssetManifestsDir)</BuildArgs> | |||
| <BuildArgs Condition="'$(OfficialBuildId)' != ''">$(BuildArgs) /p:OfficialBuildId=$(OfficialBuildId)</BuildArgs> | |||
| <BuildArgs Condition="'$(ForceDryRunSigning)' != ''">$(BuildArgs) /p:ForceDryRunSigning=$(ForceDryRunSigning)</BuildArgs> | |||
| <!-- PGO assets by default are "Vertical" visibilty. Each repo will enable the specific artifacts it must publish externally --> | |||
| <BuildArgs Condition="'$(PgoInstrument)' == 'true'">$(BuildArgs) /p:DefaultArtifactVisibility=Vertical</BuildArgs> | |||
There was a problem hiding this comment.
@ViktorHofer @jkoritzinsky Is your thinking that default artifact visibility is something that the VMR will be responsible for passing, rather than runtime setting this under certain conditions?
There was a problem hiding this comment.
I think the default visibility should be a property of the VMR for PGO as we need to tell every repo (not just runtime) that its assets are Vertical-only.
For other scenarios (like filtering out RID-agnostic packages if we wanted to get rid of the concept of a main vertical entirely) I could see runtime controlling the default rules itself.
jkoritzinsky
added
Blocked
Blocked on dotnet/arcade-validation#4745 (and subsequent Arcade flow to dotnet/sdk)
Blocked on dotnet/runtime#111513
Contributes to dotnet/source-build#4648