Add integration tests for dotnet test #46045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egration-tests-for-dotnet-test-run-functionality
dotnet-issue-labeler
bot
added
Area-DotNet Test
untriaged
Evangelink
approved these changes
Jan 16, 2025
Co-authored-by: Amaury Levé <[email protected]>
…-functionality' of https://github.com/dotnet/sdk into dev/mabdullah/add-integration-tests-for-dotnet-test-run-functionality
mariam-abdulla
commented
Jan 17, 2025
| } | ||
| else | ||
| { | ||
| bool allowBinLog = IsBinaryLoggerEnabled(_args, out string binLogFileName); | ||
| isBuiltOrRestored = BuildOrRestoreProject(solutionOrProjectFilePath, projectCollection, [CliConstants.RestoreCommand], allowBinLog, binLogFileName); |
There was a problem hiding this comment.
We still need to find a way to write a single binlog file when restoring and building for the test project case.
Because it's not working as the solution case (passing both restore and build command when building).
There was a problem hiding this comment.
it should work for single project, just like with sln. And for multiple projects you should be able to filter and build a metaproject with just those projects or something.
@JanKrivanek what is the easiest and most efficient way for us to build and restore a subset of projects from a solution?
e.g. all projects that contain *UnitTests.csproj in the name.
…et-test-run-functionality
…et-test-run-functionality
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
dotnet-testcommand to improve error handling and output reporting. The most important changes involve replacingVSTestTrace.SafeWriteTracewith_output.WriteMessagefor better integration with theTerminalTestReporter, modifying method signatures to include the new reporter, and refactoring utility methods for improved readability and maintainability.Error Handling and Output Reporting:
src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs: ReplacedVSTestTrace.SafeWriteTracewith_output.WriteMessagein various methods to improve error message reporting. [1] [2] [3] [4]src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs: AddedTerminalTestReporteras a parameter to theMSBuildHandlerconstructor and assigned it to a private field_output.Method Signature Modifications:
src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs: Changed the return type ofTryGetProjectOrSolutionFilePathto a tuple for better error messaging. [1] [2]src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs: ModifiedIsBinaryLoggerEnabledto beinternalinstead ofprivate.Code Refactoring:
src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs: Refactored theRunmethod to improve readability and maintainability by extracting logic into helper methods likeSetupCancelKeyPressHandler,InitializeHelpActionQueue, andInitializeTestExecutionActionQueue. [1] [2]src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs: Added comments to clarify the purpose of certain code blocks and skipped non-test projects during initialization. [1] [2]Cleanup:
src/Cli/dotnet/commands/dotnet-test/TestApplication.cs: Removed unused eventRunand constantsTestingPlatformVsTestBridgeRunSettingsFileEnvVarandDLLExtension. [1] [2] [3] [4]src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs: Removed unnecessaryConsole.CancelKeyPresshandler logic and unused fields. [1] [2]