Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable msbuild server by default for team internal build pipelines #11295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimaTian
Copy link
Member

Part of #9379

Context

Enable MSBuildServer for our internal pipelines so that we can start troubleshooting any issues that might arise.

Changes Made

Enabled said server by toggling the appropriate environment variables.

Testing

This is the test.

@SimaTian SimaTian requested a review from a team as a code owner January 17, 2025 08:51
@SimaTian SimaTian force-pushed the msbuild-server-internal-dogfood branch from f805574 to bbbc0ff Compare January 17, 2025 09:09
@baronfel
Copy link
Member

Just noting that this doesn't use Server for our day to day local builds - I think we want that to increase coverage?

@SimaTian
Copy link
Member Author

Current status:
kills a bunch of tests, mostly related to

  • terminal logger
  • build checks

@rainersigwald
Copy link
Member

Tests should not inherit this environment. Can you unset it with these others? (or maybe "all MSBuild* environment?)

// Clear these two environment variables first in case pre-setting affects the test.
env.SetEnvironmentVariable("MSBUILDLIVELOGGER", null);
env.SetEnvironmentVariable("MSBUILDTERMINALLOGGER", null);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants