Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure Service Bus integration doc #2365

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jan 8, 2025

Summary

Caution

Currently blocked by the release of .NET Aspire 9.1. Various APIs and xref links will not render correctly and are missing.

Rewrite Azure Service Bus integration article.

Fixes #2308


Internal previews

📄 File 🔗 Preview link
docs/messaging/azure-service-bus-integration.md .NET Aspire Azure Service Bus integration

@dotnetrepoman dotnetrepoman bot added the messaging Content related to messaging. label Jan 8, 2025
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-health KR: Concerns article defects/freshness or build warnings. label Jan 8, 2025
@IEvangelist IEvangelist requested a review from CamSoper January 8, 2025 20:08
@IEvangelist IEvangelist marked this pull request as draft January 8, 2025 20:08
@IEvangelist IEvangelist changed the title Fixes #2308 Update Azure Service Bus integration doc Jan 8, 2025
@CamSoper CamSoper requested a review from Copilot January 8, 2025 20:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

{
Tier = ServiceBusSkuTier.Premium
};
serviceBusNamespace.Tags.Add("ExampleKey", "Example value");
Copy link
Preview

Copilot AI Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag value 'Example value' should be 'ExampleValue' to maintain consistency with typical naming conventions.

Suggested change
serviceBusNamespace.Tags.Add("ExampleKey", "Example value");
serviceBusNamespace.Tags.Add("ExampleKey", "ExampleValue");

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree but whatever

Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there any way to do passwordless in Aspire? Should we include that information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
messaging Content related to messaging. okr-quality Content-health KR: Concerns article defects/freshness or build warnings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite of the Azure Service Bus integration article
2 participants