Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Keycloak admin variable names in extensions #7124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Keycloak admin variable names in extensions #7124

wants to merge 2 commits into from
+4 −4

Conversation

paulomorgado
Copy link

Description

Renamed constants for Keycloak admin username and password in the KeycloakResourceBuilderExtensions class from KEYCLOAK_ADMIN and KEYCLOAK_ADMIN_PASSWORD to KC_BOOTSTRAP_ADMIN_USERNAME and KC_BOOTSTRAP_ADMIN_PASSWORD. This change aligns with https://www.keycloak.org/docs/26.0.0/upgrading/#admin-bootstrapping-and-recovery.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@paulomorgado
Update Keycloak admin variable names in extensions
8d74f74 
Renamed constants for Keycloak admin username and password in the `KeycloakResourceBuilderExtensions` class from `KEYCLOAK_ADMIN` and `KEYCLOAK_ADMIN_PASSWORD` to `KC_BOOTSTRAP_ADMIN_USERNAME` and `KC_BOOTSTRAP_ADMIN_PASSWORD`. This change aligns with https://www.keycloak.org/docs/26.0.0/upgrading/#admin-bootstrapping-and-recovery.
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 15, 2025
@davidfowl
Copy link
Member

So keycloak is broken today?

@paulomorgado
Copy link
Author

So keycloak is broken today?

Not yet! But I don't know when it will be,

@davidfowl
Copy link
Member

I think you need to update some tests

@paulomorgado
Refactor Keycloak admin environment variables
7eb2952 
Removed `KEYCLOAK_ADMIN` and `KEYCLOAK_ADMIN_PASSWORD`
and replaced them with `KC_BOOTSTRAP_ADMIN_USERNAME`
and `KC_BOOTSTRAP_ADMIN_PASSWORD` for improved naming
convention while maintaining functionality.
@build-analysis build-analysis bot mentioned this pull request Jan 16, 2025
Open
3 tasks
@paulomorgado
Copy link
Author

@davidfowl, fixed the tests, but I don't understand why it's failing for Linux.

@DamianEdwards
Copy link
Member

Change seems fine.

@DamianEdwards
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianEdwards DamianEdwards Awaiting requested review from DamianEdwards

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulomorgado @davidfowl @DamianEdwards