chore: infra configuration refactored #6286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-exp
requested review from
prakarsh-dt,
vikramdevtron,
nishant-d and
vivek-devtron
as code owners
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
kartik-579
requested changes
Jan 15, 2025
Comment on lines
47
to
56
| switch configKey { | ||
| case v1.CPU_LIMIT, v1.CPU_REQUEST: | ||
| return impl.getCPUConfigFactory().formatTypedValueAsString(configValue) | ||
| case v1.MEMORY_LIMIT, v1.MEMORY_REQUEST: | ||
| return impl.getMemoryConfigFactory().formatTypedValueAsString(configValue) | ||
| case v1.TIME_OUT: | ||
| return impl.getTimeoutConfigFactory().formatTypedValueAsString(configValue) | ||
| default: | ||
| return "", fmt.Errorf("config key %q not supported", configKey) | ||
| } |
There was a problem hiding this comment.
ideally ent files should not contain any business logic. If this are to be used in oss let's move these to normal file
Comment on lines
55
to
61
| profileIds := make([]int, 0) | ||
| infraProfilesEntities, err := impl.infraProfileRepo.GetProfileListByIds(profileIds, includeDefault) | ||
| if err != nil { | ||
| impl.logger.Errorw("error in fetching profile entities by ids", "scope", scope, "profileIds", profileIds, "error", err) | ||
| return nil, profileIds, err | ||
| } | ||
| return infraProfilesEntities, profileIds, err |
|
The migration files have successfully passed the criteria!! |
|
The migration files have successfully passed the criteria!! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?