Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libsci
was being linked twice, from OpenMP and the libsci module. This caused a warning at runtime which which was making the regression test fail to parse the JSON output... Disabling that module results in another error: a few CUDA test fail to link with the following error:test/celeritas/CMakeFiles/celeritas_phys_Particle.dir/phys/Particle.test.cu.o: undefined reference to symbol 'dlclose@@GLIBC_2.2.5'
. I looked at the symbolParticle.test.cu.o
and there is indeeddlclose
, it is not clear to me who is bringing that symbol there.The failure only happens with VecGeom build, the ORANGE build has
-ldl
in the linker invocation, I don't know why it's different for VecGeom. Just work around it by settingCMAKE_EXE_LINKER_FLAGS
...