Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kuberay] Adding the list and watch for endpoints resource to the cluster role to solve #30648 #31226

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

frivas-at-navteca
Copy link

This change adds the necessary rules to the operator cluster role to get the Ray Service in Running state and also make the kuberay operator not to show the

W1127 12:42:08.725162       1 reflector.go:539] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:kuberay:kuberay-operator" cannot list resource "endpoints" in API group "" at the cluster scope
E1127 12:42:08.725465       1 reflector.go:147] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.Endpoints: failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:kuberay:kuberay-operator" cannot list resource "endpoints" in API group "" at the cluster scope
W1127 12:42:57.122692       1 reflector.go:539] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:kuberay:kuberay-operator" cannot list resource "endpoints" in API group "" at the cluster scope
E1127 12:42:57.122732       1 reflector.go:147] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.Endpoints: failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:kuberay:kuberay-operator" cannot list resource "endpoints" in API group "" at the cluster scope
W1127 12:43:42.058024       1 reflector.go:539] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:kuberay:kuberay-operator" cannot list resource "endpoints" in API group "" at the cluster scope
E1127 12:43:42.058075       1 reflector.go:147] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.Endpoints: failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:kuberay:kuberay-operator" cannot list resource "endpoints" in API group "" at the cluster scope
W1127 12:44:29.551260       1 reflector.go:539] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:kuberay:kuberay-operator" cannot list resource "endpoints" in API group "" at the cluster scope
E1127 12:44:29.551308       1 reflector.go:147] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.Endpoints: failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:kuberay:kuberay-operator" cannot list resource "endpoints" in API group "" at the cluster scope

This issue has been seen in the operator's log and as I am not using the apiserver or cluster components

Description of the change

Adds RBAC rules to the Operator Cluster Role.

Benefits

Ray Service will be in running state and also the Operator logs won't show the messages with the permissions.

Possible drawbacks

None as far as I know. Just keep in mind this applies only to the operator not apiserver or cluster.

Applicable issues

@github-actions github-actions bot added kuberay triage Triage is needed labels Jan 7, 2025
@github-actions github-actions bot requested a review from carrodher January 7, 2025 11:36
@frivas-at-navteca
Copy link
Author

Re-opening. Sorry for the delay with this. I hope you have had a Merry Christmas and a Happy New Year and the 3 Kings had been great to you.

I have synched my fork and it should be fine now.

Thank you very much for all the support and lets get this through!

@carrodher
Copy link
Member

Thanks for your contribution! Could you please bump the chart version in the Chart.yaml? This is necessary to test the changes and cut a new release.

frivas-at-navteca and others added 2 commits January 7, 2025 14:37
Signed-off-by: Francisco Rivas <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 10, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 10, 2025
@github-actions github-actions bot removed the request for review from carrodher January 10, 2025 19:07
@github-actions github-actions bot requested a review from alvneiayu January 10, 2025 19:07
Signed-off-by: Bitnami Containers <[email protected]>
@frivas-at-navteca
Copy link
Author

Hello @carrodher and @alvneiayu I hope you are doing great!

I was wondering about this PR. I have seen there are 2 new releases of Kuberay solving other important issues. I was wondering if this one will be included in a future release.

Thank you for your support and help

Thank you very much!
have a great day!

carrodher and others added 2 commits January 17, 2025 13:16
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress kuberay verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/kuberay] Missing Cluster Role rules causes Ray Service to be in WaitForServeDeploymentReady
4 participants