Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/vault] Fix missing existing PVC volume declaration (#31202) #31211

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[bitnami/vault] Fix missing existing PVC volume declaration (#31202) #31211

wants to merge 2 commits into from

Conversation

fredleb
Copy link

@fredleb fredleb commented Jan 3, 2025

Description of the change

Add a valid volume declaration in case an existing PVC is provided and persistence is enabled.

Benefits

  • Ability to use existing claims
  • No need to to use "extraVolumes" workaround

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added vault triage Triage is needed labels Jan 3, 2025
@github-actions github-actions bot requested a review from javsalgar January 3, 2025 16:10
@bitnami-bot
Update CHANGELOG.md
cae06ee 
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 3, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 3, 2025
@github-actions github-actions bot removed the request for review from javsalgar January 3, 2025 19:02
@github-actions github-actions bot requested a review from migruiz4 January 3, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migruiz4 migruiz4 Awaiting requested review from migruiz4

At least 1 approving review is required to merge this pull request.

Assignees

@migruiz4 migruiz4

Labels
in-progress vault verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/vault] Using existing PVC for data fails
5 participants
@fredleb @javsalgar @carrodher @migruiz4 @bitnami-bot