Array modal's fields now keyboard accessible

[stuartromanek]

Summary

• Ensures array modals' existing fields are keyboard accessible when modal is opened.
• Ensures new array items' fields are keyboard accessible when added
• Change the array editor's isModified method to a computed prop for consistency with other components

What are the specific steps to test this change?

1. Check these two scenarios
   https://github.com/user-attachments/assets/b1e1f42d-982c-4b13-ba12-4552dae470b3

Tests

https://github.com/apostrophecms/testbed/actions/runs/12794762166

What kind of change does this PR introduce?

(Check at least one)

• Bug fix

[stuartromanek]

@ValJed Unrelated to main pr, but i noticed array's isModified is a function, not a boolean. The bug it was causing was that array modals always acted as if they had been modified and threw a confirm when exiting a clean modal.

[ValJed]

oh wow nicely spotted, wouldn't it be a better solution to use a computed everywhere or a function ?

[ValJed]

Question about strat.

[ValJed]

oh wow nicely spotted, wouldn't it be a better solution to use a computed everywhere or a function ?

[stuartromanek]

wouldn't it be a better solution to use a computed everywhere or a function ?

That sounds right to me.

I'm already doing too much in some of these PRs .. how would you want to move on a computed? Should i back out my fix and make a ticket for a better a solution? Or leave this and make the ticket anyway, knowing that this could change?

[ValJed]

@stuartromanek very sorry for that late reply never saw the mention.
I would say you can keep your fix as it is but it would be nice to create a ticket that explain this weird thing (isModified being a computed or a function) and that we should use computed (or function) everywhere for clarity. With a link to the code you added in this PR to check if it's a function or computed, wdyt?

[stuartromanek]

@ValJed It wasn't as involved to make the upstream change as I thought, so I've converted the array modal's isModified method to a computed property and reverted the double check I initially had here. Running updated tests now but I think this is a solid fix.