Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the combined add-in & Teams tab sample #1527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updates to the combined add-in & Teams tab sample #1527

wants to merge 1 commit into from

Conversation

Rick-Kirkham
Copy link
Contributor

@Rick-Kirkham Rick-Kirkham commented Jan 13, 2025 •
edited
Loading

This PR updates the add-in part of the sample for a combined Teams tab and Office add-in.

  1. The add-in now uses new Office.js APIs to automatically reflect changes in the user's chosen Office theme.
  2. The latest versions of the office-addin-* utility libraries are used.
  3. In the manifest, the deprecated "file" property is replaced with the "url" property.
  4. The deprecated teams-fx CLI is replaced with the teamsapp-CLI (only in the add-in part of the sample)
  5. The sample ReadMe is updated to account for items 1 - 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mohammed-MSFT Mohammed-MSFT Awaiting requested review from Mohammed-MSFT

@Harikrishnan-MSFT Harikrishnan-MSFT Awaiting requested review from Harikrishnan-MSFT

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rick-Kirkham