Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: prepare libhtp.rs aliases for htp opaque htp_tx_t #12419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/2696

Describe changes:

  • prepare libhtp-rs by defining aliases for the new values used by libhtp-rs

This allow to go one small step further

The big libhtp-rs commit will remove app-layer-htp-libhtp.h which defines these aliases

#12407 next round

In preparation of libhtp rust
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 79.14110% with 68 lines in your changes missing coverage. Please review.

Project coverage is 80.64%. Comparing base (8f6795d) to head (23050d7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12419   +/-   ##
=======================================
  Coverage   80.63%   80.64%           
=======================================
  Files         918      918           
  Lines      258696   258712   +16     
=======================================
+ Hits       208598   208636   +38     
+ Misses      50098    50076   -22     
Flag Coverage Δ
fuzzcorpus 56.81% <66.39%> (+<0.01%) ⬆️
livemode 19.40% <0.00%> (-0.01%) ⬇️
pcap 44.31% <55.06%> (+<0.01%) ⬆️
suricata-verify 63.26% <68.01%> (+0.02%) ⬆️
unittests 58.52% <42.02%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24251

@victorjulien victorjulien added this to the 8.0 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants