Refactor state classes to prepare for state corruption backup mitigation #29745
+838
−437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture sentry error if there is an empty/corrupt vault, and handle more possible empty/corrupt vault types Ensure log.debug call in case fetch in init in ReadOnlyNetworkStore has an error without a message Ensure that in ReadOnlyNetworkStore waits for initializing to complete Lint fix Ensure that first time state is returned if state has no data Update app/scripts/lib/Stores/ExtensionStore.ts Co-authored-by: Danica Shen <[email protected]> Update test description Use const for DEFAULT_INITIAL_STATE in ExtensionStore.test.ts Improve naming and usage of versionedData variable in background.js lint fix Capture exception with sentry in both error cases ExtensionStore.get Lint fix Add app/scripts/lib/Stores/ReadOnlyNetworkStore.test.ts Delete files that are no longer used Use async/await for get/set in ExtensionStore.ts
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist