fix #4720: Handle empty events array in trace dataset loading #6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlonge4
changed the title
dosubot
bot
added
the
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in BUG attempting to load parquet tracing file throws ValueError #4720.
The
Typeofrow.get("events")isnumpy.ndarraywhen reading in a trace dataset that was previously saved.The changes made ensure that the
eventsfield in the trace dataset is handled correctly, preventing errors related to ambiguous truth values when processing empty arrays.Key Changes:
eventsfield is now explicitly checked for its type..tolist().This ensures consistent behavior and avoids
TypeErrorwhen evaluating empty lists.