Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for o1 dev messages + reasoning param #6110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cephalization
Copy link
Contributor

  • o1 now supports "system" messages by converting them to "developer" before sending to openai
  • o1 now supports "reasoning effort" parameter of values "low" "medium" and "high"

Limitations:

  • o1 models no longer support streaming. Unclear if temporary regression.
  • o1-mini does not support "developer" messages or "system" messages
  • o1-mini does not support "reasoning effort"

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 17, 2025
@@ -193,7 +193,7 @@ pass_env=
PHOENIX_SMTP_USERNAME
PHOENIX_SMTP_PASSWORD
commands_pre =
uv tool install arize-phoenix@. \
uv tool install -U --force arize-phoenix@. \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this kill the cache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our deps don't upgrade otherwise. Was causing crashes when running with pnpm dev

It seemed to still cache for me until a dep needed upgrading but someone with a cache will need to pull down and see what pnpm dev does

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cool - I just hate it when I can't run phoenix on planes. haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: 📘 Todo
Development

Successfully merging this pull request may close these issues.

2 participants