Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Support ChunkGraph option in CacheGroup['test'] of SplitChunksPlugin #8988

Open
h-a-n-a opened this issue Jan 10, 2025 · 2 comments
Open

[Feature]: Support ChunkGraph option in CacheGroup['test'] of SplitChunksPlugin #8988

h-a-n-a opened this issue Jan 10, 2025 · 2 comments
Assignees
@JSerFeng
Labels
contrib: easy feat New feature or request PR welcome team The issue/pr is created by the member of Rspack.

Comments

@h-a-n-a
Copy link
Contributor

h-a-n-a commented Jan 10, 2025 •
edited
Loading

What problem does this feature solve?

https://webpack.js.org/plugins/split-chunks-plugin/#splitchunkscachegroupscachegrouptest

What does the proposed API of configuration look like?

https://webpack.js.org/plugins/split-chunks-plugin/#splitchunkscachegroupscachegrouptest

ChunkGraph is already implemented in Compilation. You just need to add this into test function call.
@h-a-n-a h-a-n-a added feat New feature or request pending triage The issue/PR is currently untouched. and removed pending triage The issue/PR is currently untouched. labels Jan 10, 2025
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 10, 2025
@inottn
Copy link
Collaborator

inottn commented Jan 10, 2025

It seems the moduleGraph isn't being passed either. Do we need to support it?

@JSerFeng JSerFeng self-assigned this Jan 13, 2025
@JSerFeng
Copy link
Contributor

It seems the moduleGraph isn't being passed either. Do we need to support it?

Good catch, I'll add this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JSerFeng JSerFeng

Labels
contrib: easy feat New feature or request PR welcome team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@h-a-n-a @inottn @JSerFeng