Draft: fix: align amd option behavior with webpack
#9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
nilptr
commented
Jan 14, 2025
| @@ -372,7 +372,7 @@ export const getNormalizedRspackOptions = ( | |||
| watchOptions: cloneObject(config.watchOptions), | |||
| devServer: config.devServer, | |||
| profile: config.profile, | |||
| amd: config.amd ? JSON.stringify(config.amd) : undefined, | |||
| amd: config.amd !== false ? JSON.stringify(config.amd || {}) : undefined, | |||
There was a problem hiding this comment.
webpack does not explicitly specify a default value for amd option. however, undefined is equivalent to {} in the implementation. ref
this change ensures the behavior is consistent with webpack. but i'm wondering if we should explicitly state the default value is {}. what do you think?
There was a problem hiding this comment.
moved this line to getRawOptions.
CodSpeed Performance ReportMerging #9011 will not alter performanceComparing Summary
|
nilptr
changed the title
amd option behavior with webpack and add doc for amd optionamd option behavior with webpack
github-actions
bot
added
the
release: bug fix
nilptr
changed the title
amd option behavior with webpackamd option behavior with webpack
github-actions
bot
removed
the
release: bug fix
nilptr
force-pushed
the
nilptr/refactor/amd-doc
branch
2 times, most recently
from
415b69c to
a13a6da
Compare
nilptr
commented
Jan 16, 2025
| _expr: &swc_core::ecma::ast::CallExpr, | ||
| for_name: &str, | ||
| ) -> Option<bool> { | ||
| (parser.is_esm && is_non_esm_identifier(for_name)).then_some(true) |
There was a problem hiding this comment.
if the module is an esm, define/typeof define/define(...) processing will be skipped by HarmonyDetectionParserPlugin.
nilptr
force-pushed
the
nilptr/refactor/amd-doc
branch
from
a13a6da to
c0460c7
Compare
chore(normal/parsing/unsupport-require-property): require.amd should not be undefined now chore(normal/parsing/unsupport-require-property): require.version & require.onError to be discussed
chore: add more test cases for amd require
nilptr
force-pushed
the
nilptr/refactor/amd-doc
branch
from
c0460c7 to
7431665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #8987
amdoption behavior with webpackamdoptionChecklist